Feature/issue 595 - Progress Bar Seek Feature#749
Open
bilal-alsharifi wants to merge 6 commits intodevelopfrom
Open
Feature/issue 595 - Progress Bar Seek Feature#749bilal-alsharifi wants to merge 6 commits intodevelopfrom
bilal-alsharifi wants to merge 6 commits intodevelopfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #749 +/- ##
=============================================
- Coverage 41.01% 40.81% -0.21%
- Complexity 2643 2652 +9
=============================================
Files 362 363 +1
Lines 15853 16035 +182
Branches 1695 1723 +28
=============================================
+ Hits 6502 6544 +42
- Misses 9044 9186 +142
+ Partials 307 305 -2
Continue to review full report at Codecov.
|
bilal-alsharifi
changed the title
joeygrover
reviewed
May 23, 2018
| public OnSeekMediaClockTimer(Hashtable<String, Object> hash) { | ||
| super(hash); | ||
| } | ||
| /** |
Member
There was a problem hiding this comment.
Please add constructor with mandatory params included
joeygrover
reviewed
May 23, 2018
| * <td>Defines if seek media clock timer functionality will be available.</td> | ||
| * <td>N</td> | ||
| * <td>If omitted, the value is set to false. The value is retained until the next SetMediaClockTimer is sent.</td> | ||
| * <td>SmartDeviceLink 4.7</td> |
Member
There was a problem hiding this comment.
This will be RPC spec 4.6, not 4.7
joeygrover
reviewed
May 23, 2018
| * <td>Describes the hour, minute and second values used for the current media clock timer.</td> | ||
| * <td>Y</td> | ||
| * <td></td> | ||
| * <td>SmartDeviceLink 4.7</td> |
Member
There was a problem hiding this comment.
This will be RPC spec 4.6, not 4.7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #595
This PR is ready for review.
Risk
This PR makes minor API changes.
Testing Plan
Summary
This PR implements the progress bar seek feature as described in the proposal.
CLA